[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/25] qapi: Improve reporting of invalid 'if' errors
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 18/25] qapi: Improve reporting of invalid 'if' errors |
|
Date: |
Tue, 24 Sep 2019 13:01:48 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/24/19 8:28 AM, Markus Armbruster wrote:
> Move check_if() from check_keys() to check_exprs() and call it later,
> so its error messages gain an "in definition" line.
>
> Checking values in a function named check_keys() is unclean anyway.
> The original sin was commit 0545f6b887 "qapi: Better error messages
> for bad expressions", which checks the value of key 'name'. More
> sinning in commit 2cbf09925a "qapi: More rigorous checking for type
> safety bypass", commit c818408e44 "qapi: Implement boxed types for
> commands/events", and commit 967c885108 "qapi: add 'if' to top-level
> expressions". This commit does penance for the latter. The next
> commits will do penance for the others.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 11/25] qapi: Report invalid '*' prefix like any other invalid name, (continued)
- [PATCH 24/25] qapi: Improve reporting of redefinition, Markus Armbruster, 2019/09/24
- [PATCH 15/25] qapi: Inline check_name() into check_union(), Markus Armbruster, 2019/09/24
- [PATCH 07/25] qapi: Improve reporting of member name clashes, Markus Armbruster, 2019/09/24
- [PATCH 13/25] qapi: Make check_type()'s array case a bit more obvious, Markus Armbruster, 2019/09/24
- [PATCH 18/25] qapi: Improve reporting of invalid 'if' errors, Markus Armbruster, 2019/09/24
- Re: [PATCH 18/25] qapi: Improve reporting of invalid 'if' errors,
Eric Blake <=
- [PATCH 12/25] qapi: Move check for reserved names out of add_name(), Markus Armbruster, 2019/09/24
- [PATCH 22/25] qapi: Eliminate check_keys(), rename check_known_keys(), Markus Armbruster, 2019/09/24
- [PATCH 19/25] qapi: Improve reporting of invalid flags, Markus Armbruster, 2019/09/24
- [PATCH 20/25] qapi: Improve reporting of missing / unknown definition keys, Markus Armbruster, 2019/09/24