[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine ty
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type |
Date: |
Wed, 25 Sep 2019 13:20:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 25/09/19 13:04, Sergio Lopez wrote:
> Yes, that would do the trick. There's another use of it at
> hw/intc/ioapic.c:78, but we should be safe as, at least in the case of
> Linux, DM_EXTINT is only used in check_timer(), which is only called if
> it detects a i8259 PIC.
Even there it is actually LVT0's DM_EXTINT, not the IOAPIC's. I think
pic_read_irq would have returned 7 (spurious IRQ on master i8259) until
commit 29bb5317cb ("i8259: QOM cleanups", 2013-04-29), so we should fix it.
Paolo
> We should probably add an assertion with an informative message, just in
> case.
signature.asc
Description: OpenPGP digital signature
- [PATCH v4 6/8] roms: add microvm-bios (qboot) as binary and git submodule, (continued)
- [PATCH v4 6/8] roms: add microvm-bios (qboot) as binary and git submodule, Sergio Lopez, 2019/09/24
- [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Sergio Lopez, 2019/09/24
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Paolo Bonzini, 2019/09/24
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Sergio Lopez, 2019/09/25
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Paolo Bonzini, 2019/09/25
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Sergio Lopez, 2019/09/25
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Paolo Bonzini, 2019/09/25
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Sergio Lopez, 2019/09/25
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type,
Paolo Bonzini <=
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Sergio Lopez, 2019/09/25
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Paolo Bonzini, 2019/09/25
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Sergio Lopez, 2019/09/26
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Paolo Bonzini, 2019/09/26
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Sergio Lopez, 2019/09/26
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Paolo Bonzini, 2019/09/26
- Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Sergio Lopez, 2019/09/26
Re: [PATCH v4 7/8] docs/microvm.txt: document the new microvm machine type, Gerd Hoffmann, 2019/09/25