[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/22] iotests: Resolve TODOs in 041
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH 18/22] iotests: Resolve TODOs in 041 |
Date: |
Thu, 26 Sep 2019 14:09:42 +0000 |
20.09.2019 18:28, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/041 | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index d91f538276..ca126de3ff 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -921,8 +921,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
>
> self.complete_and_wait(drive="job0")
> self.assert_has_block_node("repair0", quorum_repair_img)
> - # TODO: a better test requiring some QEMU infrastructure will be
> added
> - # to check that this file is really driven by quorum
> + self.vm.assert_block_path('quorum0/children.1', 'repair0')
> self.vm.shutdown()
> self.assertTrue(iotests.compare_images(quorum_img2,
> quorum_repair_img),
> 'target image does not match source after
> mirroring')
> @@ -1074,9 +1073,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
>
> self.complete_and_wait('job0')
> self.assert_has_block_node("repair0", quorum_repair_img)
> - # TODO: a better test requiring some QEMU infrastructure will be
> added
> - # to check that this file is really driven by quorum
> - self.vm.shutdown()
> + self.vm.assert_block_path('quorum0/children.1', 'repair0')
>
> # Test mirroring with a source that does not have any parents (not even a
> # BlockBackend)
>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
--
Best regards,
Vladimir
- Re: [PATCH 17/22] iotests: Add VM.assert_block_path(), (continued)
- [PATCH 15/22] mirror: Prevent loops, Max Reitz, 2019/09/20
- [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum, Max Reitz, 2019/09/20
- [PATCH 21/22] iotests: Check that @replaces can replace filters, Max Reitz, 2019/09/20
- [PATCH 20/22] iotests: Add tests for invalid Quorum @replaces, Max Reitz, 2019/09/20
- [PATCH 18/22] iotests: Resolve TODOs in 041, Max Reitz, 2019/09/20
- Re: [PATCH 18/22] iotests: Resolve TODOs in 041,
Vladimir Sementsov-Ogievskiy <=
- [PATCH 22/22] iotests: Mirror must not attempt to create loops, Max Reitz, 2019/09/20