Re: [PATCH v25 00/22] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PATCH v25 00/22] Add RX archtecture support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
1a74ffc qapi/machine.json: Add RX cpu.
c173e68 BootLinuxConsoleTest: Test the RX-Virt machine
b4e9a7a Add rx-softmmu
5bdc07e hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
2496aa4 hw/rx: Honor -accel qtest
b97a84d hw/rx: RX Target hardware definition
f806e27 hw/char: RX62N serial communication interface (SCI)
bd59212 hw/timer: RX62N internal timer modules
cb22efa hw/intc: RX62N interrupt controller (ICUa)
ae43531 target/rx: Dump bytes for each insn during disassembly
26dd1a2 target/rx: Collect all bytes during disassembly
18aeea2 target/rx: Emit all disassembly in one prt()
17d9d21 target/rx: Use prt_ldmi for XCHG_mr disassembly
2882571 target/rx: Replace operand with prt_ldmi in disassembler
bf3b3f2 target/rx: Disassemble rx_index_addr into a string
73102ce target/rx: RX disassembler
90cb197 target/rx: CPU definition
5c00dbb target/rx: TCG helper
2b15272 target/rx: TCG translation
15f28f1 hw/registerfields.h: Add 8bit and 16bit register macros
fa571c7 qemu/bitops.h: Add extract8 and extract16
15bf923 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 15bf92348a56 (MAINTAINERS: Add RX)
2/22 Checking commit fa571c7ef6af (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 15f28f1299de (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 2b1527203652 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 5c00dbb5e309 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 90cb19738c00 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 588 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 73102ce10f6a (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit bf3b3f236e0b (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit 2882571a240d (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit 17d9d217fe49 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit 18aeea285a8b (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit 26dd1a2ced54 (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit ae43531ca84d (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit cb22efa8a743 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit bd592129660e (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit f806e2744e16 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 401 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit b97a84d22e8e (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 2496aa433eca (hw/rx: Honor -accel qtest)
19/22 Checking commit 5bdc07e394ef (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit b4e9a7ab9c9e (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 59 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit c173e68e70b7 (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit 1a74ffc35710 (qapi/machine.json: Add RX cpu.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden