|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH] slirp: Allow non-local DNS address when restrict is off |
Date: | Tue, 1 Oct 2019 11:04:32 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
Hi Samuel, On 9/29/19 8:13 PM, Samuel Thibault wrote:
This can be used to set a DNS server to be used by the guest which is different from the one configured on the host. This fixes LP 1010484.
Wow, 7 years old... Can you use this format, easier to understand for newcomers: Fixes: https://bugs.launchpad.net/qemu/+bug/1010484
Signed-off-by: Samuel Thibault <address@hidden> --- net/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/slirp.c b/net/slirp.c index f42f496641..4d158b0542 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -456,7 +456,7 @@ static int net_slirp_init(NetClientState *peer, const char *model, error_setg(errp, "Failed to parse DNS"); return -1; } - if ((dns.s_addr & mask.s_addr) != net.s_addr) { + if (restricted && (dns.s_addr & mask.s_addr) != net.s_addr) { error_setg(errp, "DNS doesn't belong to network"); return -1; }
What about the IPv6 DNS? Regards, Phil.
[Prev in Thread] | Current Thread | [Next in Thread] |