[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 02/31] hw/core/loader-fit: fix freeing errp in fit_load_fdt
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v4 02/31] hw/core/loader-fit: fix freeing errp in fit_load_fdt |
Date: |
Tue, 1 Oct 2019 18:52:50 +0300 |
fit_load_fdt forget to check that errp is not NULL and to zero it after
freeing. Fix it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
hw/core/loader-fit.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/core/loader-fit.c b/hw/core/loader-fit.c
index 953b16bc82..3ee9fb2f2e 100644
--- a/hw/core/loader-fit.c
+++ b/hw/core/loader-fit.c
@@ -200,7 +200,10 @@ static int fit_load_fdt(const struct fit_loader *ldr,
const void *itb,
err = fit_image_addr(itb, img_off, "load", &load_addr, errp);
if (err == -ENOENT) {
load_addr = ROUND_UP(kernel_end, 64 * KiB) + (10 * MiB);
- error_free(*errp);
+ if (errp) {
+ error_free(*errp);
+ *errp = NULL;
+ }
} else if (err) {
error_prepend(errp, "unable to read FDT load address from FIT: ");
ret = err;
--
2.21.0
[PATCH v4 02/31] hw/core/loader-fit: fix freeing errp in fit_load_fdt,
Vladimir Sementsov-Ogievskiy <=
[PATCH v4 08/31] ARM TCG CPUs: Fix error_append_hint/error_prepend usage, Vladimir Sementsov-Ogievskiy, 2019/10/01
[PATCH v4 12/31] ASPEED BMCs: Fix error_append_hint/error_prepend usage, Vladimir Sementsov-Ogievskiy, 2019/10/01
[PATCH v4 15/31] PCI: Fix error_append_hint/error_prepend usage, Vladimir Sementsov-Ogievskiy, 2019/10/01
[PATCH v4 14/31] PowerNV (Non-Virtualized): Fix error_append_hint/error_prepend usage, Vladimir Sementsov-Ogievskiy, 2019/10/01
[PATCH v4 09/31] PowerPC TCG CPUs: Fix error_append_hint/error_prepend usage, Vladimir Sementsov-Ogievskiy, 2019/10/01
[PATCH v4 10/31] arm: Fix error_append_hint/error_prepend usage, Vladimir Sementsov-Ogievskiy, 2019/10/01
[PATCH v4 13/31] Boston: Fix error_append_hint/error_prepend usage, Vladimir Sementsov-Ogievskiy, 2019/10/01
[PATCH v4 11/31] SmartFusion2: Fix error_append_hint/error_prepend usage, Vladimir Sementsov-Ogievskiy, 2019/10/01