Re: [PATCH 3/7] qapi: Eliminate accidental global frontend state

[Eric Blake]

On 10/1/19 2:15 PM, Markus Armbruster wrote:
> The frontend can't be run more than once due to its global state.
> A future commit will want to do that.
>
> The only global frontend state remaining is accidental:
> QAPISchemaParser.__init__()'s parameter previously_included=[].
> Python evaluates the default once, at definition time.  Any
> modifications to it are visible in subsequent calls.  Well-known
> Python trap.  Change the default to None and replace it by the real
> default in the function body.  Use the opportunity to convert
> previously_included to a set.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   scripts/qapi/common.py | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org