qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 18/19] hw/timer: Declare device little or big en


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH 18/19] hw/timer: Declare device little or big endian
Date: Wed, 2 Oct 2019 13:17:09 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 8/26/19 4:21 PM, Tony Nguyen wrote:
For each device declared with DEVICE_NATIVE_ENDIAN, find the set of
targets from the set of target/hw/*/device.o.

If the set of targets are all little or all big endian, re-declare
as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.

Then, on inspection:
- if not used, re-declare as DEVICE_HOST_ENDIAN.
- if max/min size=1, re-declare as DEVICE_HOST_ENDIAN.
- if just a bit bucket, re-declare as DEVICE_HOST_ENDIAN
- if PCI, re-declare as DEVICE_LITTLE_ENDIAN.
- if for {ARM|unicore32} only, re-declare as DEVICE_LITTLE_ENDIAN.
- if for SPARC only, re-declare as DEVICE_BIG_ENDIAN.

Signed-off-by: Tony Nguyen <address@hidden>
---
  hw/timer/a9gtimer.c         | 4 ++--
  hw/timer/arm_mptimer.c      | 4 ++--
  hw/timer/arm_timer.c        | 4 ++--
  hw/timer/armv7m_systick.c   | 2 +-
  hw/timer/aspeed_rtc.c       | 2 +-
  hw/timer/cadence_ttc.c      | 2 +-
  hw/timer/grlib_gptimer.c    | 2 +-
  hw/timer/hpet.c             | 2 +-
  hw/timer/imx_epit.c         | 2 +-
  hw/timer/imx_gpt.c          | 2 +-
  hw/timer/lm32_timer.c       | 2 +-
  hw/timer/milkymist-sysctl.c | 2 +-
  hw/timer/mss-timer.c        | 2 +-
  hw/timer/pl031.c            | 2 +-
  hw/timer/puv3_ost.c         | 2 +-
  hw/timer/slavio_timer.c     | 2 +-
  hw/timer/stm32f2xx_timer.c  | 2 +-
  hw/timer/sun4v-rtc.c        | 2 +-

This patch affects various areas, maybe it is worth splitting in at least big/little changes? Or 3: ARM first, then big/little.

[...]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]