[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum
From: |
Max Reitz |
Subject: |
Re: [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum |
Date: |
Wed, 2 Oct 2019 14:42:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 26.09.19 16:13, Vladimir Sementsov-Ogievskiy wrote:
> 20.09.2019 18:28, Max Reitz wrote:
>> 041's TestRepairQuorum has its own image_len, no need to refer to
>> TestSingleDrive. (This patch allows uncommenting TestSingleDrive to
>
> you mean commenting
Ah, yes, I mean commenting out. :-)
>> speed up 041 during test testing.)
>
> we definitely want a way to run a subset of test cases.
>
> I usually do s/def test/def ntest/, and then set needed test-case back to
> 'def test'
Thanks for that tip.
Max
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> tests/qemu-iotests/041 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
>> index ca126de3ff..20ae9750b7 100755
>> --- a/tests/qemu-iotests/041
>> +++ b/tests/qemu-iotests/041
>> @@ -880,7 +880,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
>> # Add each individual quorum images
>> for i in self.IMAGES:
>> qemu_img('create', '-f', iotests.imgfmt, i,
>> - str(TestSingleDrive.image_len))
>> + str(self.image_len))
>
> yes, seems TestSingleDrive.image_len is a copy-pasting mistake here..
>
>> # Assign a node name to each quorum image in order to
>> manipulate
>> # them
>> opts = "node-name=img%i" % self.IMAGES.index(i)
>>
>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum,
Max Reitz <=