[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iotests: Do not run the iotests during "make check" anymore
From: |
Alex Bennée |
Subject: |
Re: [PATCH] iotests: Do not run the iotests during "make check" anymore |
Date: |
Wed, 02 Oct 2019 18:32:10 +0100 |
User-agent: |
mu4e 1.3.4; emacs 27.0.50 |
Daniel P. Berrangé <address@hidden> writes:
> On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote:
>> Running the iotests during "make check" is causing more headaches than
>> benefits for the block layer maintainers, so let's disable the iotests
>> during "make check" again.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>> tests/Makefile.include | 2 +-
>> tests/qemu-iotests/group | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> I don't have any objection to removing from 'make check', but I feel
> like this commit should be modifying the travis.yml config so that
> it explicitly runs the block tests, otherwise we're loosing automated
> CI and the block tests will increase their rate of bitrot again.
I think we run a subset on gitlab as well. Do the iotests need any
particular build of QEMU? Lets try and avoid adding unneeded targets.
I must admit I've been out of the loop here. What headaches are they
causing? Too many false positives?
>
>
> Regards,
> Daniel
--
Alex Bennée
Re: [PATCH] iotests: Do not run the iotests during "make check" anymore,
Alex Bennée <=
Re: [PATCH] iotests: Do not run the iotests during "make check" anymore, Max Reitz, 2019/10/07