[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/6] qcow2: advanced compression options
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 0/6] qcow2: advanced compression options |
Date: |
Wed, 02 Oct 2019 21:04:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Max Reitz <address@hidden> writes:
> On 02.10.19 17:35, Vladimir Sementsov-Ogievskiy wrote:
>> Hi,
>>
>> 02.10.2019 18:07, address@hidden wrote:
>>> Patchew URL: https://patchew.org/QEMU/address@hidden/
>>>
>>>
>>>
>>> Hi,
>>>
>>> This series failed the docker-quick@centos7 build test. Please find the
>>> testing commands and
>>> their output below. If you have Docker installed, you can probably
>>> reproduce it
>>> locally.
>>>
>>> === TEST SCRIPT BEGIN ===
>>> #!/bin/bash
>>> make docker-image-centos7 V=1 NETWORK=1
>>> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
>>> === TEST SCRIPT END ===
>>>
>>> CC block/parallels.o
>>> CC block/blklogwrites.o
>>> CC block/block-backend.o
>>> /tmp/qemu-test/src/block/qcow2.c:4077:64: error: unknown type name 'AioTask'
>>> static coroutine_fn int qcow2_co_pwritev_compressed_task_entry(AioTask
>>> *task)
>>> ^
>>> /tmp/qemu-test/src/block/qcow2.c: In function
>>> 'qcow2_co_pwritev_compressed_part':
>>> /tmp/qemu-test/src/block/qcow2.c:4098:5: error: unknown type name
>>> 'AioTaskPool'
>>> AioTaskPool *aio = NULL;
>>> ^
>>
>>
>> Who knows, what is wrong with it? Seems patchew ignores Based-on: tag in
>> cover-letter,
>> which is written as "Based-on: https://github.com/XanClic/qemu.git block"...
>> These new types and functions are defined in Max's block branch.
>
> It would be news to me if Patchew supported such URLs. I just put it
> into my cover letter for human reviewers...
>
> (Actually, it would be news to me if Patchew supported Based-on at all
> reliably...)
https://github.com/patchew-project/patchew/commit/5e461e7c49c1913cb34349f45cc7566627b37288
I use Based-on: <Message-Id> all the time, and it works reliably for me.