Re: [PATCH v5 01/10] hw/virtio: Factorize virtio-mmio headers

[Eric Blake]

On 10/3/19 6:26 AM, Sergio Lopez wrote:
> Philippe Mathieu-Daudé <address@hidden> writes:
>
> > On 10/2/19 1:30 PM, Sergio Lopez wrote:
> > > Put QOM and main struct definition in a separate header file, so it
> > > can be accessed from other components.
> > >
> > > Signed-off-by: Sergio Lopez <address@hidden>

> > > +
> > > +#ifndef QEMU_VIRTIO_MMIO_H
> > > +#define QEMU_VIRTIO_MMIO_H
> >
> > I'd rather use HW_VIRTIO_MMIO_H
>
> Looks like there isn't a consensus in this regard:
>
> $ grep "ifndef" *

> Do we have an actual policy written somewhere?

Past history shows several cleanups near commit fe2611b016, including 
commit c0a9956b which mentions scripts/clean-header-guards specifically 
for this purpose.  So yes, we have a policy, although it is not always 
enforced in a timely manner.


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org