[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 08/10] roms: add microvm-bios (qboot) as binary and git su
From: |
Stefano Garzarella |
Subject: |
Re: [PATCH v6 08/10] roms: add microvm-bios (qboot) as binary and git submodule |
Date: |
Fri, 4 Oct 2019 13:50:08 +0200 |
User-agent: |
NeoMutt/20180716 |
On Fri, Oct 04, 2019 at 11:37:50AM +0200, Sergio Lopez wrote:
> qboot is a minimalist x86 firmware for booting Linux kernels. It does
> the mininum amount of work required for the task, and it's able to
> boot both PVH images and bzImages without relying on option roms.
>
> This characteristics make it an ideal companion for the microvm
> machine type.
>
> Signed-off-by: Sergio Lopez <address@hidden>
> ---
> .gitmodules | 3 +++
> pc-bios/bios-microvm.bin | Bin 0 -> 65536 bytes
> roms/Makefile | 6 ++++++
> roms/qboot | 1 +
> 4 files changed, 10 insertions(+)
> create mode 100755 pc-bios/bios-microvm.bin
> create mode 160000 roms/qboot
>
> diff --git a/.gitmodules b/.gitmodules
> index c5c474169d..19792c9a11 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -58,3 +58,6 @@
> [submodule "roms/opensbi"]
> path = roms/opensbi
> url = https://git.qemu.org/git/opensbi.git
> +[submodule "roms/qboot"]
> + path = roms/qboot
> + url = https://github.com/bonzini/qboot
> diff --git a/pc-bios/bios-microvm.bin b/pc-bios/bios-microvm.bin
> new file mode 100755
Others rom have 644 permissions, should we be aligned or doesn't matter?
Anyway this patch LGTM:
Reviewed-by: Stefano Garzarella <address@hidden>
- Re: [PATCH v6 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them, (continued)
- [PATCH v6 04/10] hw/i386: split PCMachineState deriving X86MachineState from it, Sergio Lopez, 2019/10/04
- [PATCH v6 05/10] hw/i386: make x86.c independent from PCMachineState, Sergio Lopez, 2019/10/04
- [PATCH v6 06/10] fw_cfg: add "modify" functions for all types, Sergio Lopez, 2019/10/04
- [PATCH v6 07/10] hw/intc/apic: reject pic ints if isa_pic == NULL, Sergio Lopez, 2019/10/04
- [PATCH v6 08/10] roms: add microvm-bios (qboot) as binary and git submodule, Sergio Lopez, 2019/10/04
- Re: [PATCH v6 08/10] roms: add microvm-bios (qboot) as binary and git submodule,
Stefano Garzarella <=
- [PATCH v6 09/10] docs/microvm.rst: document the new microvm machine type, Sergio Lopez, 2019/10/04
- [PATCH v6 10/10] hw/i386: Introduce the microvm machine type, Sergio Lopez, 2019/10/04
- Re: [PATCH v6 00/10] Introduce the microvm machine type, Michael S. Tsirkin, 2019/10/04
- Re: [PATCH v6 00/10] Introduce the microvm machine type, no-reply, 2019/10/04
- Re: [PATCH v6 00/10] Introduce the microvm machine type, no-reply, 2019/10/04
- Re: [PATCH v6 00/10] Introduce the microvm machine type, Michael S. Tsirkin, 2019/10/05