[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 29/29] target/i386/kvm: Silence warning from Valgrind about uninit
From: |
Paolo Bonzini |
Subject: |
[PULL 29/29] target/i386/kvm: Silence warning from Valgrind about uninitialized bytes |
Date: |
Fri, 4 Oct 2019 18:59:23 +0200 |
From: Thomas Huth <address@hidden>
When I run QEMU with KVM under Valgrind, I currently get this warning:
Syscall param ioctl(generic) points to uninitialised byte(s)
at 0x95BA45B: ioctl (in /usr/lib64/libc-2.28.so)
by 0x429DC3: kvm_ioctl (kvm-all.c:2365)
by 0x51B249: kvm_arch_get_supported_msr_feature (kvm.c:469)
by 0x4C2A49: x86_cpu_get_supported_feature_word (cpu.c:3765)
by 0x4C4116: x86_cpu_expand_features (cpu.c:5065)
by 0x4C7F8D: x86_cpu_realizefn (cpu.c:5242)
by 0x5961F3: device_set_realized (qdev.c:835)
by 0x7038F6: property_set_bool (object.c:2080)
by 0x707EFE: object_property_set_qobject (qom-qobject.c:26)
by 0x705814: object_property_set_bool (object.c:1338)
by 0x498435: pc_new_cpu (pc.c:1549)
by 0x49C67D: pc_cpus_init (pc.c:1681)
Address 0x1ffeffee74 is on thread 1's stack
in frame #2, created by kvm_arch_get_supported_msr_feature (kvm.c:445)
It's harmless, but a little bit annoying, so silence it by properly
initializing the whole structure with zeroes.
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
target/i386/kvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index be4bbfb..11b9c85 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -188,7 +188,7 @@ static int kvm_get_tsc(CPUState *cs)
struct {
struct kvm_msrs info;
struct kvm_msr_entry entries[1];
- } msr_data;
+ } msr_data = {};
int ret;
if (env->tsc_valid) {
@@ -448,7 +448,7 @@ uint64_t kvm_arch_get_supported_msr_feature(KVMState *s,
uint32_t index)
struct {
struct kvm_msrs info;
struct kvm_msr_entry entries[1];
- } msr_data;
+ } msr_data = {};
uint64_t value;
uint32_t ret, can_be_one, must_be_one;
--
1.8.3.1
- [PULL v3 00/29] Misc patches for 2019-10-02, Paolo Bonzini, 2019/10/04
- [PULL 22/29] target/i386: handle filtered_features in a new function mark_unavailable_features, Paolo Bonzini, 2019/10/04
- [PULL 23/29] target/i386: introduce generic feature dependency mechanism, Paolo Bonzini, 2019/10/04
- [PULL 24/29] target/i386: expand feature words to 64 bits, Paolo Bonzini, 2019/10/04
- [PULL 25/29] target/i386: add VMX definitions, Paolo Bonzini, 2019/10/04
- [PULL 26/29] vmxcap: correct the name of the variables, Paolo Bonzini, 2019/10/04
- [PULL 27/29] target/i386: add VMX features, Paolo Bonzini, 2019/10/04
- [PULL 28/29] target/i386: work around KVM_GET_MSRS bug for secondary execution controls, Paolo Bonzini, 2019/10/04
- [PULL 29/29] target/i386/kvm: Silence warning from Valgrind about uninitialized bytes,
Paolo Bonzini <=
- Re: [PULL v3 00/29] Misc patches for 2019-10-02, Peter Maydell, 2019/10/07