[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/19] tests: document how to update acpi tables
From: |
Michael S. Tsirkin |
Subject: |
[PULL 15/19] tests: document how to update acpi tables |
Date: |
Sat, 5 Oct 2019 17:59:53 -0400 |
Looks like no one understands how to do it.
Document the process.
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
tests/bios-tables-test.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 652a78773f..0b33fb265f 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -10,6 +10,33 @@
* See the COPYING file in the top-level directory.
*/
+/*
+ * How to add or update the tests:
+ * Contributor:
+ * 1. add empty files for new tables, if any, under tests/data/acpi
+ * 2. list any changed files in tests/bios-tables-test-allowed-diff.h
+ * 3. commit the above *before* making changes that affect the tables
+ * Maintainer:
+ * After 1-3 above tests will pass but ignore differences with the expected
files.
+ * You will also notice that tests/bios-tables-test-allowed-diff.h lists
+ * a bunch of files. This is your hint that you need to do the below:
+ * 4. Run
+ * make check V=1
+ * this will produce a bunch of warnings about differences
+ * beween actual and expected ACPI tables. If you have IASL installed,
+ * they will also be disassembled so you can look at the disassembled
+ * output. If not - disassemble them yourself in any way you like.
+ * Look at the differences - make sure they make sense and match what the
+ * changes you are merging are supposed to do.
+ *
+ * 5. From build directory, run:
+ * $(SRC_PATH)/tests/data/acpi/rebuild-expected-aml.sh
+ * 6. Now commit any changes.
+ * 7. Before doing a pull request, make sure
tests/bios-tables-test-allowed-diff.h
+ * is empty - this will ensure following changes to ACPI tables will
+ * be noticed.
+ */
+
#include "qemu/osdep.h"
#include <glib/gstdio.h>
#include "qemu-common.h"
--
MST
- [PULL 05/19] hw/arm/virt: Add memory hotplug framework, (continued)
- [PULL 05/19] hw/arm/virt: Add memory hotplug framework, Michael S. Tsirkin, 2019/10/05
- [PULL 06/19] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot, Michael S. Tsirkin, 2019/10/05
- [PULL 07/19] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT, Michael S. Tsirkin, 2019/10/05
- [PULL 08/19] hw/arm: Factor out powerdown notifier from GPIO, Michael S. Tsirkin, 2019/10/05
- [PULL 09/19] hw/arm: Use GED for system_powerdown event, Michael S. Tsirkin, 2019/10/05
- [PULL 10/19] docs/specs: Add ACPI GED documentation, Michael S. Tsirkin, 2019/10/05
- [PULL 11/19] tests: Update ACPI tables list for upcoming arm/virt tests, Michael S. Tsirkin, 2019/10/05
- [PULL 12/19] tests/acpi: add empty files, Michael S. Tsirkin, 2019/10/05
- [PULL 13/19] tests: allow empty expected files, Michael S. Tsirkin, 2019/10/05
- [PULL 14/19] tests: Add bios tests to arm/virt, Michael S. Tsirkin, 2019/10/05
- [PULL 15/19] tests: document how to update acpi tables,
Michael S. Tsirkin <=
- [PULL 16/19] tests/acpi: add expected tables for arm/virt, Michael S. Tsirkin, 2019/10/05
- [PULL 17/19] virtio: Add virtio_fs linux headers, Michael S. Tsirkin, 2019/10/05
- [PULL 18/19] virtio: add vhost-user-fs base device, Michael S. Tsirkin, 2019/10/05
- Re: [PULL 18/19] virtio: add vhost-user-fs base device, Igor Mammedov, 2019/10/07
- [PULL 19/19] virtio: add vhost-user-fs-pci device, Michael S. Tsirkin, 2019/10/05
- Re: [PULL 00/19] virtio, vhost, acpi: features, fixes, tests, Peter Maydell, 2019/10/07