qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 7/7] tests/fw_cfg: Run the tests on big-endian targets


From: Peter Maydell
Subject: Re: [PATCH v2 7/7] tests/fw_cfg: Run the tests on big-endian targets
Date: Tue, 8 Oct 2019 21:35:09 +0100

On Tue, 8 Oct 2019 at 21:29, Laszlo Ersek <address@hidden> wrote:
> In that case, the original initializer will remain in effect, from:
>
>   QTestCtx ctx = {};
>
> (Admittedly, this is an ugly GNU-ism; for standard C, it should be
>
>   QTestCtx ctx = { 0 };
>
> but the GNU-ism is used quite frequently in QEMU elsewhere, so meh :) )

This is deliberate -- some compilers grumble about "{ 0 }" in
some situations, so we generally recommend using "{}" which
is accepted by all compilers we care about. (Cf commit message
for commit 039d4e3df0049bdd.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]