[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime
From: |
Richard Henderson |
Subject: |
Re: [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime |
Date: |
Wed, 9 Oct 2019 20:50:02 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 10/7/19 1:06 PM, Andrew Jones wrote:
> +static void kvm_arm_vm_state_change(void *opaque, int running, RunState
> state)
> +{
> + CPUState *cs = opaque;
> + ARMCPU *cpu = ARM_CPU(cs);
> +
> + if (running) {
> + if (cpu->kvm_adjvtime) {
> + kvm_arm_set_virtual_time(cs);
> + }
> + }
> +}
Worth putting this in kvm.c too, so you don't have to duplicate it? You can
always split it apart later if you ever do need a different hook for 32 vs 64.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [RFC PATCH 0/5] target/arm/kvm: Provide an option to adjust virtual time, Andrew Jones, 2019/10/07
- [RFC PATCH 1/5] target/arm/kvm64: kvm64 cpus have timer registers, Andrew Jones, 2019/10/07
- [RFC PATCH 2/5] timer: arm: Introduce functions to get the host cntfrq, Andrew Jones, 2019/10/07
- [RFC PATCH 4/5] tests/arm-cpu-features: Check feature default values, Andrew Jones, 2019/10/07
- [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime, Andrew Jones, 2019/10/07
- Re: [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime,
Richard Henderson <=
- [RFC PATCH 5/5] target/arm/cpu: Add the kvm-adjvtime CPU property, Andrew Jones, 2019/10/07