Re: [PATCH v4 0/4] qapi: Add detection for the 'savevm' fix for blockdev

[Peter Krempa]

On Fri, Oct 11, 2019 at 10:50:23 +0200, Markus Armbruster wrote:
> Add 'features' field in the schema for commands and add a feature flag
> to advertise that the fix for savevm [1] is present.
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03487.html
> 
> Based-on: <address@hidden>
> 
> v4:
>  - PATCH 1: New
>  - PATCH 2: Factor out check_features()
>  - PATCH 3: Factor out _print_features(), drop duplicated test
>  - PATCH 4: Shorten savevm-blockdev-monitor-nodes to just
>             savevm-monitor-nodes; tweak commit message and
>           documentation

Thanks for fixing the problems in 2-4, they all look good to me. Adding
a reviewed-by in this case would not be appropriate.

signature.asc
Description: PGP signature