Re: [PATCH v3 1/6] target/mips: Clean up helper.c

[Markus Armbruster]

Aleksandar Markovic <address@hidden> writes:

> From: Aleksandar Markovic <address@hidden>
>
> Mostly fix errors and warnings reported by 'checkpatch.pl -f'.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>  target/mips/helper.c | 128 
> +++++++++++++++++++++++++++++++--------------------
>  1 file changed, 78 insertions(+), 50 deletions(-)
>
> diff --git a/target/mips/helper.c b/target/mips/helper.c
> index a2b6459..2411a2c 100644
> --- a/target/mips/helper.c
> +++ b/target/mips/helper.c
[...]
> @@ -130,8 +133,11 @@ static int is_seg_am_mapped(unsigned int am, bool eu, 
> int mmu_idx)
>      int32_t adetlb_mask;
>  
>      switch (mmu_idx) {
> -    case 3 /* ERL */:
> -        /* If EU is set, always unmapped */
> +    case 3:
> +        /*
> +         * ERL
> +         * If EU is set, always unmapped
> +         */
>          if (eu) {
>              return 0;
>          }

Did you miss my review comment?

Message-ID: <address@hidden>
https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg06719.html

[...]