[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 68/68] hw/misc/bcm2835_mbox: Add trace events
From: |
Peter Maydell |
Subject: |
[PULL 68/68] hw/misc/bcm2835_mbox: Add trace events |
Date: |
Mon, 14 Oct 2019 17:04:04 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
Add trace events for read/write accesses and IRQ.
Properties are structures used for the ARM particular MBOX.
Since one call in bcm2835_property.c concerns the mbox block,
name this trace event in the same bcm2835_mbox* namespace.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>
---
hw/misc/bcm2835_mbox.c | 5 +++++
hw/misc/bcm2835_property.c | 2 ++
hw/misc/trace-events | 6 ++++++
3 files changed, 13 insertions(+)
diff --git a/hw/misc/bcm2835_mbox.c b/hw/misc/bcm2835_mbox.c
index 77285624c9f..77d2d80706c 100644
--- a/hw/misc/bcm2835_mbox.c
+++ b/hw/misc/bcm2835_mbox.c
@@ -15,6 +15,7 @@
#include "migration/vmstate.h"
#include "qemu/log.h"
#include "qemu/module.h"
+#include "trace.h"
#define MAIL0_PEEK 0x90
#define MAIL0_SENDER 0x94
@@ -123,6 +124,7 @@ static void bcm2835_mbox_update(BCM2835MboxState *s)
set = true;
}
}
+ trace_bcm2835_mbox_irq(set);
qemu_set_irq(s->arm_irq, set);
}
@@ -178,8 +180,10 @@ static uint64_t bcm2835_mbox_read(void *opaque, hwaddr
offset, unsigned size)
default:
qemu_log_mask(LOG_UNIMP, "%s: Unsupported offset 0x%"HWADDR_PRIx"\n",
__func__, offset);
+ trace_bcm2835_mbox_read(size, offset, res);
return 0;
}
+ trace_bcm2835_mbox_read(size, offset, res);
bcm2835_mbox_update(s);
@@ -195,6 +199,7 @@ static void bcm2835_mbox_write(void *opaque, hwaddr offset,
offset &= 0xff;
+ trace_bcm2835_mbox_write(size, offset, value);
switch (offset) {
case MAIL0_SENDER:
break;
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index 43a5465c5dc..0eea2e20f79 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -13,6 +13,7 @@
#include "sysemu/dma.h"
#include "qemu/log.h"
#include "qemu/module.h"
+#include "trace.h"
/* https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface */
@@ -283,6 +284,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState
*s, uint32_t value)
break;
}
+ trace_bcm2835_mbox_property(tag, bufsize, resplen);
if (tag == 0) {
break;
}
diff --git a/hw/misc/trace-events b/hw/misc/trace-events
index 74276225f81..1deb1d08c19 100644
--- a/hw/misc/trace-events
+++ b/hw/misc/trace-events
@@ -143,3 +143,9 @@ armsse_mhu_write(uint64_t offset, uint64_t data, unsigned
size) "SSE-200 MHU wri
# aspeed_xdma.c
aspeed_xdma_write(uint64_t offset, uint64_t data) "XDMA write: offset 0x%"
PRIx64 " data 0x%" PRIx64
+
+# bcm2835_mbox.c
+bcm2835_mbox_write(unsigned int size, uint64_t addr, uint64_t value) "mbox
write sz:%u addr:0x%"PRIx64" data:0x%"PRIx64
+bcm2835_mbox_read(unsigned int size, uint64_t addr, uint64_t value) "mbox read
sz:%u addr:0x%"PRIx64" data:0x%"PRIx64
+bcm2835_mbox_irq(unsigned level) "mbox irq:ARM level:%u"
+bcm2835_mbox_property(uint32_t tag, uint32_t bufsize, size_t resplen) "mbox
property tag:0x%08x in_sz:%u out_sz:%zu"
--
2.20.1
- [PULL 59/68] aspeed: Add an AST2600 eval board, (continued)
- [PULL 59/68] aspeed: Add an AST2600 eval board, Peter Maydell, 2019/10/14
- [PULL 56/68] aspeed: Introduce an object class per SoC, Peter Maydell, 2019/10/14
- [PULL 57/68] aspeed/soc: Add AST2600 support, Peter Maydell, 2019/10/14
- [PULL 60/68] aspeed: Parameterise number of MACs, Peter Maydell, 2019/10/14
- [PULL 61/68] aspeed: add support for the Aspeed MII controller of the AST2600, Peter Maydell, 2019/10/14
- [PULL 62/68] aspeed/soc: Add ASPEED Video stub, Peter Maydell, 2019/10/14
- [PULL 63/68] hw/arm/raspi: Use the IEC binary prefix definitions, Peter Maydell, 2019/10/14
- [PULL 64/68] hw/arm/bcm2835_peripherals: Improve logging, Peter Maydell, 2019/10/14
- [PULL 65/68] hw/arm/bcm2835_peripherals: Name various address spaces, Peter Maydell, 2019/10/14
- [PULL 66/68] hw/arm/bcm2835: Rename some definitions, Peter Maydell, 2019/10/14
- [PULL 68/68] hw/misc/bcm2835_mbox: Add trace events,
Peter Maydell <=
- [PULL 67/68] hw/arm/bcm2835: Add various unimplemented peripherals, Peter Maydell, 2019/10/14