[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/18] hw/misc/vmcoreinfo: Add comment about reset handler
From: |
Eduardo Habkost |
Subject: |
[PULL 11/18] hw/misc/vmcoreinfo: Add comment about reset handler |
Date: |
Tue, 15 Oct 2019 18:37:38 -0300 |
From: Philippe Mathieu-Daudé <address@hidden>
The VM coreinfo device does not sit on a bus, so it won't be
reset automatically. This is why it calls qemu_register_reset().
Add a comment about it, so we don't convert its reset handler
to a DeviceReset method.
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Li Qiang <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/misc/vmcoreinfo.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c
index 326a3ce8f4..a9d718fc23 100644
--- a/hw/misc/vmcoreinfo.c
+++ b/hw/misc/vmcoreinfo.c
@@ -61,6 +61,10 @@ static void vmcoreinfo_realize(DeviceState *dev, Error
**errp)
NULL, fw_cfg_vmci_write, s,
&s->vmcoreinfo, sizeof(s->vmcoreinfo), false);
+ /*
+ * This device requires to register a global reset because it is
+ * not plugged to a bus (which, as its QOM parent, would reset it).
+ */
qemu_register_reset(vmcoreinfo_reset, dev);
vmcoreinfo_state = s;
}
--
2.21.0
- [PULL 01/18] tests: add qtest_qmp_device_add_qdict() helper, (continued)
- [PULL 01/18] tests: add qtest_qmp_device_add_qdict() helper, Eduardo Habkost, 2019/10/15
- [PULL 02/18] tests: cpu-plug-test: fix device_add for pc/q35 machines, Eduardo Habkost, 2019/10/15
- [PULL 03/18] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node, Eduardo Habkost, 2019/10/15
- [PULL 04/18] hw/acpi/piix4: Convert reset handler to DeviceReset, Eduardo Habkost, 2019/10/15
- [PULL 05/18] hw/isa/piix4: Convert reset handler to DeviceReset, Eduardo Habkost, 2019/10/15
- [PULL 06/18] hw/ide/piix: Convert reset handler to DeviceReset, Eduardo Habkost, 2019/10/15
- [PULL 07/18] hw/ide/sii3112: Convert reset handler to DeviceReset, Eduardo Habkost, 2019/10/15
- [PULL 08/18] hw/ide/via82c: Convert reset handler to DeviceReset, Eduardo Habkost, 2019/10/15
- [PULL 09/18] hw/isa/vt82c686: Convert reset handler to DeviceReset, Eduardo Habkost, 2019/10/15
- [PULL 10/18] hw/input/lm832x: Convert reset handler to DeviceReset, Eduardo Habkost, 2019/10/15
- [PULL 11/18] hw/misc/vmcoreinfo: Add comment about reset handler,
Eduardo Habkost <=
- [PULL 12/18] memory-device: not necessary to use goto for the last check, Eduardo Habkost, 2019/10/15
- [PULL 13/18] memory-device: break the loop if tmp exceed the hinted range, Eduardo Habkost, 2019/10/15
- [PULL 14/18] target/i386: clean up comments over 80 chars per line, Eduardo Habkost, 2019/10/15
- [PULL 15/18] target/i386: drop the duplicated definition of cpuid AVX512_VBMI macro, Eduardo Habkost, 2019/10/15
- [PULL 16/18] i386: Fix legacy guest with xsave panic on host kvm without update cpuid., Eduardo Habkost, 2019/10/15
- [PULL 17/18] i386: Omit all-zeroes entries from KVM CPUID table, Eduardo Habkost, 2019/10/15
- [PULL 18/18] target/i386: Add Snowridge-v2 (no MPX) CPU model, Eduardo Habkost, 2019/10/15
- Re: [PULL 00/18] x86 and machine queue, 2019-10-15, Peter Maydell, 2019/10/18