[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL
From: |
Sergio Lopez |
Subject: |
[PATCH v10 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL |
Date: |
Wed, 16 Oct 2019 12:12:38 +0200 |
In apic_accept_pic_intr(), reject PIC interruptions if a i8259 PIC has
not been instantiated (isa_pic == NULL).
Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Sergio Lopez <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
---
hw/intc/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/apic.c b/hw/intc/apic.c
index bce89911dc..2a74f7b4bf 100644
--- a/hw/intc/apic.c
+++ b/hw/intc/apic.c
@@ -610,7 +610,7 @@ int apic_accept_pic_intr(DeviceState *dev)
if ((s->apicbase & MSR_IA32_APICBASE_ENABLE) == 0 ||
(lvt0 & APIC_LVT_MASKED) == 0)
- return 1;
+ return isa_pic != NULL;
return 0;
}
--
2.21.0
- Re: [PATCH v10 03/15] hw/i386/pc: fix code style issues on functions that will be moved out, (continued)
- [PATCH v10 04/15] hw/i386/pc: replace use of strtol with qemu_strtoui in x86_load_linux(), Sergio Lopez, 2019/10/16
- [PATCH v10 05/15] hw/i386/pc: avoid an assignment in if condition in x86_load_linux(), Sergio Lopez, 2019/10/16
- [PATCH v10 06/15] hw/i386/pc: remove commented out code from x86_load_linux(), Sergio Lopez, 2019/10/16
- [PATCH v10 07/15] hw/i386/pc: move shared x86 functions to x86.c and export them, Sergio Lopez, 2019/10/16
- [PATCH v10 08/15] hw/i386: split PCMachineState deriving X86MachineState from it, Sergio Lopez, 2019/10/16
- [PATCH v10 09/15] hw/i386: make x86.c independent from PCMachineState, Sergio Lopez, 2019/10/16
- [PATCH v10 10/15] fw_cfg: add "modify" functions for all types, Sergio Lopez, 2019/10/16
- [PATCH v10 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL,
Sergio Lopez <=
- [PATCH v10 12/15] roms: add microvm-bios (qboot) as binary and git submodule, Sergio Lopez, 2019/10/16
- [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type, Sergio Lopez, 2019/10/16
- Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type, Daniel P . Berrangé, 2019/10/17