[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation
From: |
Stefan Hajnoczi |
Subject: |
Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation |
Date: |
Fri, 18 Oct 2019 11:09:09 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Fri, Oct 18, 2019 at 09:16:36AM +0200, Miklos Szeredi wrote:
> On Thu, Oct 17, 2019 at 6:48 PM Miklos Szeredi <address@hidden> wrote:
>
> > Even simpler: allow O_PATH descriptors for f*xattr().
>
> Attached patch. Will post shortly.
>
> However, I think it would make sense to fix virtiofsd as well, as this
> will take time to percolate down, even if Al doesn't find anything
> wrong with it.
>
> Doing unshare(CLONE_FS) after thread startup seems safe, though must
> be careful to change the working directory to the root of the mount
> *before* starting any threads.
Thank you for extending O_PATH, that's great! This will be the cleanest
way to perform xattr operations.
If your patch is accepted I will send a man-pages.git patch to update
the open(2) O_PATH documentation (with a minimum kernel version).
I've added the unshare(CLONE_FS) task to my todo list in case no one
else gets to it first. I may not have time to work on it before
Novemeber though.
Stefan
signature.asc
Description: PGP signature
- [PATCH 2/2] virtiofsd: Allow setxattr operation to directry, (continued)
- [PATCH 2/2] virtiofsd: Allow setxattr operation to directry, Misono Tomohiro, 2019/10/16
- [PATCH 1/2] virtiofsd: Avoid process hang when doing xattr operation to FIFO, Misono Tomohiro, 2019/10/16
- Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, Stefan Hajnoczi, 2019/10/17
- Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, Miklos Szeredi, 2019/10/17
- Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, Stefan Hajnoczi, 2019/10/17
- Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, Miklos Szeredi, 2019/10/17
- Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, Miklos Szeredi, 2019/10/18
- Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation,
Stefan Hajnoczi <=
- RE: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, address@hidden, 2019/10/18
- Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, Stefan Hajnoczi, 2019/10/21
- RE: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, address@hidden, 2019/10/23
- Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation, Stefan Hajnoczi, 2019/10/25