[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: virtio-fs: Fix file ID collisions (was: 9p: Fix file ID collisions)
From: |
Christian Schoenebeck |
Subject: |
Re: virtio-fs: Fix file ID collisions (was: 9p: Fix file ID collisions) |
Date: |
Fri, 18 Oct 2019 15:15:43 +0200 |
On Mittwoch, 16. Oktober 2019 15:44:09 CEST Dr. David Alan Gilbert wrote:
> > > Unless I'm missing something, it seems that "virtio-fs" has the same
> > > issue we had on 9pfs before Christian's patches... :-\
> >
> > Is a fix for this desired for virtio-fs?
>
> Yes I think so; we had originally thought we were hiding the host inode
> numbers; but that's not true - since we pass both a device and inode
> number in virtiofs, unlike 9p, it seems we can probably get away with
> only remapping device IDs rather than inode numbers; but that requires
> some understanding of how multiple block device IDs are supposed to look
> like to the guest kernel.
Postponed on my side then. My original idea was simply sharing the existing
inode remapping code from 9p. But remapping/adding device ids on guest side
like you suggested is cleaner; takes more time though to lookup the required
kernel interfaces to achieve that.
Best regards,
Christian Schoenebeck