Re: [PATCH v2 07/11] tests/ssh_linux_malta: Run tests using a snapshot image

[Aleksandar Markovic]

On Saturday, October 19, 2019, Philippe Mathieu-Daudé <address@hidden> wrote:
> If a test fails, it can corrupt the underlying QCow2 image,
> making further tests failing.
> Fix this by running each test with a snapshot.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  tests/acceptance/linux_ssh_mips_malta.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Aleksandar Markovic <address@hidden>

 

> diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptance/linux_ssh_mips_malta.py
> index ffbb06f846..27907e8fbd 100644
> --- a/tests/acceptance/linux_ssh_mips_malta.py
> +++ b/tests/acceptance/linux_ssh_mips_malta.py
> @@ -90,7 +90,7 @@ class LinuxSSH(Test):
>          self.vm.add_args('-no-reboot',
>                           '-kernel', kernel_path,
>                           '-append', kernel_command_line,
> -                         '-hda', image_path,
> +                         '-drive', 'file=%s,snapshot=on' % image_path,
>                           '-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22',
>                           '-device', 'pcnet,netdev=vnet')
>          self.vm.launch()
> -- 
> 2.21.0