[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() functio
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function |
|
Date: |
Mon, 21 Oct 2019 10:04:32 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote:
> Having the RAM creation code in a separate function is not
> very helpful. Move this code directly inside the board_init()
> function, this will later allow the board to have the QOM
> ownership of the RAM.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/arm/digic_boards.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [PATCH 02/21] hw/arm/mps2: Use the IEC binary prefix definitions, (continued)
- [PATCH 03/21] hw/arm/collie: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 04/21] hw/arm/omap2: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 05/21] hw/arm/omap1: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 07/21] hw: Drop QOM ownership on memory_region_allocate_system_memory() calls, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument, Philippe Mathieu-Daudé, 2019/10/20