[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] hw/hppa/dino.c: Improve emulation of Dino PCI chip
From: |
Richard Henderson |
Subject: |
Re: [PATCH 1/7] hw/hppa/dino.c: Improve emulation of Dino PCI chip |
Date: |
Mon, 21 Oct 2019 11:26:20 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/20/19 1:47 PM, Sven Schnelle wrote:
> #define DINO_PCI_HOST_BRIDGE(obj) \
> OBJECT_CHECK(DinoState, (obj), TYPE_DINO_PCI_HOST_BRIDGE)
>
> +#define DINO800_REGS ((DINO_TLTIM - DINO_GMASK) / 4)
> +static uint8_t reg800_keep_bits[DINO800_REGS]
> + = { 1, 7, 7, 8, 7, 9, 32, 8, 30, 25, 22, 9 };
(1) const.
(2) better as a mask:
static const uint32_t reg800_keep_mask[DINO800_REGS] = {
MAKE_64BIT_MASK(0, 1),
MAKE_64BIT_MASK(0, 7),
...
};
since that's the only way this is actually used.
r~
- [PATCH 0/7] HPPA: i82596, PS/2 and graphics emulation, Sven Schnelle, 2019/10/20
- [PATCH 4/7] ps2: accept 'Set Key Make and Break' commands, Sven Schnelle, 2019/10/20
- [PATCH 1/7] hw/hppa/dino.c: Improve emulation of Dino PCI chip, Sven Schnelle, 2019/10/20
- Re: [PATCH 1/7] hw/hppa/dino.c: Improve emulation of Dino PCI chip,
Richard Henderson <=
- [PATCH 5/7] hppa: add emulation of LASI PS2 controllers, Sven Schnelle, 2019/10/20
- [PATCH 3/7] hppa: remove ISA region, Sven Schnelle, 2019/10/20
- [PATCH 6/7] hppa: Add emulation of Artist graphics, Sven Schnelle, 2019/10/20
- [PATCH 2/7] hppa: Add support for LASI chip with i82596 NIC, Sven Schnelle, 2019/10/20
- [PATCH 7/7] seabios-hppa: update to latest version, Sven Schnelle, 2019/10/20