[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()"
From: |
Esteban Bosse |
Subject: |
Re: [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()" |
Date: |
Tue, 22 Oct 2019 10:50:46 +0200 |
User-agent: |
Evolution 3.30.5-1.1 |
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió:
> From: Philippe Mathieu-Daudé <address@hidden>
>
> This function isn't used anymore.
>
> This reverts commit 22ec3283efba9ba0792790da786d6776d83f2a92.
>
> Reviewed-by: Thomas Huth <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/core/irq.c | 14 --------------
> include/hw/irq.h | 5 -----
> 2 files changed, 19 deletions(-)
>
> diff --git a/hw/core/irq.c b/hw/core/irq.c
> index 7cc0295d0e..fb3045b912 100644
> --- a/hw/core/irq.c
> +++ b/hw/core/irq.c
> @@ -120,20 +120,6 @@ qemu_irq qemu_irq_split(qemu_irq irq1, qemu_irq
> irq2)
> return qemu_allocate_irq(qemu_splitirq, s, 0);
> }
>
> -static void proxy_irq_handler(void *opaque, int n, int level)
> -{
> - qemu_irq **target = opaque;
> -
> - if (*target) {
> - qemu_set_irq((*target)[n], level);
> - }
> -}
> -
> -qemu_irq *qemu_irq_proxy(qemu_irq **target, int n)
> -{
> - return qemu_allocate_irqs(proxy_irq_handler, target, n);
> -}
> -
> void qemu_irq_intercept_in(qemu_irq *gpio_in, qemu_irq_handler
> handler, int n)
> {
> int i;
> diff --git a/include/hw/irq.h b/include/hw/irq.h
> index fe527f6f51..24ba0ece11 100644
> --- a/include/hw/irq.h
> +++ b/include/hw/irq.h
> @@ -51,11 +51,6 @@ qemu_irq qemu_irq_invert(qemu_irq irq);
> */
> qemu_irq qemu_irq_split(qemu_irq irq1, qemu_irq irq2);
>
> -/* Returns a new IRQ set which connects 1:1 to another IRQ set,
> which
> - * may be set later.
> - */
> -qemu_irq *qemu_irq_proxy(qemu_irq **target, int n);
> -
> /* For internal use in qtest. Similar to qemu_irq_split, but
> operating
> on an existing vector of qemu_irq. */
> void qemu_irq_intercept_in(qemu_irq *gpio_in, qemu_irq_handler
> handler, int n);
Reviewed-by: Esteban Bosse <address@hidden>
- Re: [PATCH v2 01/20] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets, (continued)
- [PATCH v2 02/20] piix4: Add the Reset Control Register, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()", Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 05/20] piix4: Rename PIIX4 object to piix4-isa, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 06/20] piix4: Add a i8257 DMA Controller as specified in datasheet, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 07/20] piix4: Add a i8254 PIT Controller as specified in datasheet, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 08/20] piix4: Add a MC146818 RTC Controller as specified in datasheet, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 09/20] hw/mips/mips_malta: Create IDE hard drive array dynamically, Philippe Mathieu-Daudé, 2019/10/18