[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean') |
Date: |
Wed, 23 Oct 2019 03:09:57 -0400 (EDT) |
----- Original Message -----
> From: "Aleksandar Markovic" <address@hidden>
> Sent: Tuesday, October 22, 2019 10:35:51 PM
>
> On Tuesday, October 8, 2019, Thomas Huth <address@hidden> wrote:
>
> > When running "make distclean" we currently leave a lot of generated
> > files in the build directory. These should be completely removed.
> > Some of the generated files are removed in the "clean" target (which
> > is a prerequisite for the "distclean" target), since binary files
> > should be removed in this step already.
> >
> > Signed-off-by: Thomas Huth <address@hidden>
> > ---
> > v2:
> > - Remove tests/qemu-iotests/common.env in "distclean", not in "clean"
> > - Improved patch description
> >
> > Makefile | 6 +++---
> > tests/Makefile.include | 12 +++++++++++-
> > 2 files changed, 14 insertions(+), 4 deletions(-)
> >
> > Hello, Thomas,
>
> Do you intend to send a new version of this patch?
>
> It looks to me this is a very nice clean up that definitely should go into
> 4.2, no?
I'm still planning to send a v3 of this patch, but currently I don't have time
to work on this during the next two weeks. So this will likely miss the
deadline for 4.2. Feel free to pick up my patch and send a fixed version if you
think that this should still go into 4.2. Otherwise, I'll take care of it in
5.0.
Thomas
Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean'), Aleksandar Markovic, 2019/10/22
- Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean'),
Thomas Huth <=