[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] yield_until_fd_readable: make it work with any AioContect
|
From: |
Dietmar Maurer |
|
Subject: |
Re: [PATCH v3] yield_until_fd_readable: make it work with any AioContect |
|
Date: |
Thu, 24 Oct 2019 06:58:25 +0200 (CEST) |
> > + aio_set_fd_handler(ctx, fd, false, (IOHandler *)qemu_coroutine_enter,
> > + NULL, NULL, qemu_coroutine_self());
>
> This cast is unsafe. If qemu_coroutine_enter()'s prototype is changed
> there will be no compiler warning that the prototypes are now
> incompatible.
>
> Please keep fd_coroutine_enter() so the code is type-safe.
OK. Sent v4 with suggested changes.