Re: [PATCH v5 02/11] pci: add option for net failover

[Jens Freimann]

On Thu, Oct 24, 2019 at 06:22:27PM +0100, Dr. David Alan Gilbert wrote:
> * Jens Freimann (address@hidden) wrote:
> > This patch adds a net_failover_pair_id property to PCIDev which is
> > used to link the primary device in a failover pair (the PCI dev) to
> > a standby (a virtio-net-pci) device.
> >
> > It only supports ethernet devices. Also currently it only supports
> > PCIe devices. QEMU will exit with an error message otherwise.
> >
> > Signed-off-by: Jens Freimann <address@hidden>
> > ---
> >  hw/pci/pci.c         | 17 +++++++++++++++++
> >  include/hw/pci/pci.h |  3 +++
> >  2 files changed, 20 insertions(+)
> >
> > diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> > index aa05c2b9b2..fa9b5219f8 100644
> > --- a/hw/pci/pci.c
> > +++ b/hw/pci/pci.c
> > @@ -75,6 +75,8 @@ static Property pci_props[] = {
> >                      QEMU_PCIE_LNKSTA_DLLLA_BITNR, true),
> >      DEFINE_PROP_BIT("x-pcie-extcap-init", PCIDevice, cap_present,
> >                      QEMU_PCIE_EXTCAP_INIT_BITNR, true),
> > +    DEFINE_PROP_STRING("net_failover_pair_id", PCIDevice,
> > +            net_failover_pair_id),
>
> Should we just make this 'failover_pair_id' - then when someone in the
> future figures out how to make it work for something else (e.g.
> multipath block devices) then it's all good?

Yes, I see no reason why not to rename it. 

Thanks!

regards,
Jens