|
From: | Jens Freimann |
Subject: | Re: [PATCH v5 06/11] qapi: add failover negotiated event |
Date: | Fri, 25 Oct 2019 09:51:00 +0200 |
User-agent: | NeoMutt/20180716-1376-5d6ed1 |
On Fri, Oct 25, 2019 at 07:35:28AM +0200, Markus Armbruster wrote:
We ask patch submitters to cc: subject matter experts for review. You did. When such patches touch the QAPI schema, it's best to cc the qapi schema maintainers (Eric Blake and me) as well, because we can't require all subject matter experts to be fluent in the QAPI schema language and conventions. I found this one more or less by chance.
Sorry about that, I'll make sure to get the right people next time.
Jens Freimann <address@hidden> writes:This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature was not negotiated during virtio feature negotiation. If this event is received it means any primary devices hotplugged before this were were never really added to QEMU devices.Too many negations for my poor old brain to process.
I'll try to explain better :)
Signed-off-by: Jens Freimann <address@hidden> --- qapi/net.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/qapi/net.json b/qapi/net.json index 728990f4fb..8c5f3f1fb2 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -737,3 +737,19 @@ ## { 'command': 'announce-self', 'boxed': true, 'data' : 'AnnounceParameters'} + +## +# @FAILOVER_NEGOTIATED: +# +# Emitted when VIRTIO_NET_F_STANDBY was negotiated during feature negotiation +# +# Since: 4.2 +# +# Example: +# +# <- { "event": "FAILOVER_NEGOTIATED", +# "data": {} } +# +## +{ 'event': 'FAILOVER_NEGOTIATED', + 'data': {} }The commit message at least tries to explain intended use. The doc string does not. Should it?
Sure, I'll add it.
Thanks for the review! regards,Jens
[Prev in Thread] | Current Thread | [Next in Thread] |