[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/7] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 1/7] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN |
|
Date: |
Fri, 25 Oct 2019 07:48:34 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/24/19 10:14 AM, Paolo Bonzini wrote:
> On 24/10/19 16:06, Richard Henderson wrote:
>> Richard confused ROUND_UP with QEMU_ALIGN_UP.
>
> Uh, those are both really badly named. Especially considering that
> DIV_ROUND_UP divides the result of QEMU_ALIGN_UP. Should we consider
> swapping them?!?
Perhaps not swapping, but perhaps renaming ROUND_UP to POW2_ROUND_UP or
something. I dunno, naming is hard. :-P
r~
[PATCH v2 6/7] exec: Promote TARGET_PAGE_MASK to target_long, Richard Henderson, 2019/10/23
[PATCH v2 5/7] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG, Richard Henderson, 2019/10/23
[PATCH v2 7/7] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/23
[PATCH v2 3/7] configure: Detect compiler support for __attribute__((alias)), Richard Henderson, 2019/10/23
[PATCH v2 2/7] exec: Split out variable page size support to exec-vary.c, Richard Henderson, 2019/10/23
[PATCH v2 4/7] exec: Use const alias for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/23