qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v14 11/11] tests/bios-tables-test: add test cases for ACPI HM


From: Tao Xu
Subject: Re: [PATCH v14 11/11] tests/bios-tables-test: add test cases for ACPI HMAT
Date: Mon, 28 Oct 2019 16:50:18 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 10/28/2019 4:39 PM, Michael S. Tsirkin wrote:
On Mon, Oct 28, 2019 at 03:52:20PM +0800, Tao Xu wrote:
ACPI table HMAT has been introduced, QEMU now builds HMAT tables for
Heterogeneous Memory with boot option '-numa node'.

Add test cases on PC and Q35 machines with 2 numa nodes.
Because HMAT is generated when system enable numa, the
following tables need to be added for this test:
   tests/acpi-test-data/pc/*.acpihmat
   tests/acpi-test-data/pc/HMAT.*
   tests/acpi-test-data/q35/*.acpihmat
   tests/acpi-test-data/q35/HMAT.*

Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Daniel Black <address@hidden>
Reviewed-by: Jingqi Liu <address@hidden>
Suggested-by: Igor Mammedov <address@hidden>
Signed-off-by: Tao Xu <address@hidden>
---

No changes in v14.

Changes in v13:
     - Use decimal notation with appropriate suffix for cache size

As you have seen adding tests like this breaks CI.
Pls see the comment at the beginning of tests/bios-tables-test.c
for how to add tests without breaking CI.


Thanks for reminding me.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]