[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 10/12] cputlb: Fix tlb_vaddr_to_host
From: |
Richard Henderson |
Subject: |
[PULL v2 10/12] cputlb: Fix tlb_vaddr_to_host |
Date: |
Mon, 28 Oct 2019 15:59:35 +0100 |
Using uintptr_t instead of target_ulong meant that, for 64-bit guest
and 32-bit host, we truncated the guest address comparator and so may
not hit the tlb when we should.
Fixes: 4811e9095c0
Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
accel/tcg/cputlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index 6f4194df96..5eebddcca8 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1189,7 +1189,7 @@ void *tlb_vaddr_to_host(CPUArchState *env, abi_ptr addr,
MMUAccessType access_type, int mmu_idx)
{
CPUTLBEntry *entry = tlb_entry(env, mmu_idx, addr);
- uintptr_t tlb_addr, page;
+ target_ulong tlb_addr, page;
size_t elt_ofs;
switch (access_type) {
--
2.17.1
- [PULL v2 00/12] tcg patch queue, Richard Henderson, 2019/10/28
- [PULL v2 02/12] cputlb: ensure _cmmu helper functions follow the naming standard, Richard Henderson, 2019/10/28
- [PULL v2 04/12] exec: Split out variable page size support to exec-vary.c, Richard Henderson, 2019/10/28
- [PULL v2 05/12] configure: Detect compiler support for __attribute__((alias)), Richard Henderson, 2019/10/28
- [PULL v2 08/12] exec: Promote TARGET_PAGE_MASK to target_long, Richard Henderson, 2019/10/28
- [PULL v2 09/12] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/28
- [PULL v2 10/12] cputlb: Fix tlb_vaddr_to_host,
Richard Henderson <=
- [PULL v2 01/12] tci: Add implementation for INDEX_op_ld16u_i64, Richard Henderson, 2019/10/28
- [PULL v2 03/12] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN, Richard Henderson, 2019/10/28
- [PULL v2 06/12] exec: Use const alias for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/28
- [PULL v2 12/12] translate-all: Remove tb_alloc, Richard Henderson, 2019/10/28
- [PULL v2 07/12] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG, Richard Henderson, 2019/10/28
- [PULL v2 11/12] translate-all: fix uninitialized tb->orig_tb, Richard Henderson, 2019/10/28
- Re: [PULL v2 00/12] tcg patch queue, no-reply, 2019/10/28
- Re: [PULL v2 00/12] tcg patch queue, Peter Maydell, 2019/10/29