[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 05/11] qapi: add unplug primary event
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v7 05/11] qapi: add unplug primary event |
Date: |
Tue, 29 Oct 2019 13:50:02 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Jens Freimann <address@hidden> writes:
> This event is emitted when we sent a request to unplug a
Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we
received"?
> failover primary device from the Guest OS and it includes the
> device id of the primary device.
>
> Signed-off-by: Jens Freimann <address@hidden>
> ---
> qapi/migration.json | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 82feb5bd39..e9e7a97c03 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1448,3 +1448,22 @@
> # Since: 3.0
> ##
> { 'command': 'migrate-pause', 'allow-oob': true }
> +
> +##
> +# @UNPLUG_PRIMARY:
> +#
> +# Emitted from source side of a migration when migration state is
> +# WAIT_UNPLUG. Device was unplugged by guest operating system.
> +# Device resources in QEMU are kept on standby to be able to re-plug it in
> case
> +# of migration failure.
> +#
> +# @device-id: QEMU device id of the unplugged device
> +#
> +# Since: 4.2
> +#
> +# Example:
> +# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} }
> +#
> +##
> +{ 'event': 'UNPLUG_PRIMARY',
> + 'data': { 'device-id': 'str' } }
Commit message might need a touch-up. Regardless:
Acked-by: Markus Armbruster <address@hidden>
- [PATCH v7 0/11] add failover feature for assigned network devices, Jens Freimann, 2019/10/29
- [PATCH v7 01/11] qdev/qbus: add hidden device support, Jens Freimann, 2019/10/29
- [PATCH v7 02/11] pci: add option for net failover, Jens Freimann, 2019/10/29
- [PATCH v7 03/11] pci: mark devices partially unplugged, Jens Freimann, 2019/10/29
- [PATCH v7 04/11] pci: mark device having guest unplug request pending, Jens Freimann, 2019/10/29
- [PATCH v7 05/11] qapi: add unplug primary event, Jens Freimann, 2019/10/29
- Re: [PATCH v7 05/11] qapi: add unplug primary event,
Markus Armbruster <=
- [PATCH v7 06/11] qapi: add failover negotiated event, Jens Freimann, 2019/10/29
- [PATCH v7 07/11] migration: allow unplug during migration for failover devices, Jens Freimann, 2019/10/29
- [PATCH v7 08/11] migration: add new migration state wait-unplug, Jens Freimann, 2019/10/29
- [PATCH v7 09/11] libqos: tolerate wait-unplug migration state, Jens Freimann, 2019/10/29
- [PATCH v7 10/11] net/virtio: add failover support, Jens Freimann, 2019/10/29
- [PATCH v7 11/11] vfio: unplug failover primary device before migration, Jens Freimann, 2019/10/29