[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] i386: Add missing cpu feature bits in EPYC model
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH 1/2] i386: Add missing cpu feature bits in EPYC model |
|
Date: |
Tue, 5 Nov 2019 21:32:50 -0300 |
On Wed, Nov 06, 2019 at 12:16:53AM +0000, Moger, Babu wrote:
[...]
> > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > > index 51b72439b4..a72fe1db31 100644
> > > --- a/hw/i386/pc.c
> > > +++ b/hw/i386/pc.c
> > > @@ -105,7 +105,13 @@ struct hpet_fw_config hpet_cfg = {.count =
> > UINT8_MAX};
> > > /* Physical Address of PVH entry point read from kernel ELF NOTE */
> > > static size_t pvh_start_addr;
> > >
> > > -GlobalProperty pc_compat_4_1[] = {};
> > > +GlobalProperty pc_compat_4_1[] = {
> > > + { "EPYC" "-" TYPE_X86_CPU, "perfctr-core", "off" },
> > > + { "EPYC" "-" TYPE_X86_CPU, "clzero", "off" },
> > > + { "EPYC" "-" TYPE_X86_CPU, "xsaveerptr", "off" },
> > > + { "EPYC" "-" TYPE_X86_CPU, "ibpb", "off" },
> > > + { "EPYC" "-" TYPE_X86_CPU, "xsaves", "off" },
> > > +};
> >
> > machine-type-based CPU compatibility was now replaced by
> > versioned CPU models. Please use the X86CPUDefinition.versions
> > field to add a new version of EPYC instead.
>
> Ok. Did you mean like this commit below?
> fd63c6d1a5f77d68 ("i386: Add Cascadelake-Server-v2 CPU model")
Correct. Thanks!
--
Eduardo