Re: [PATCH v3 00/12] linux-user sparc fixes

[Laurent Vivier]

Le 06/11/2019 à 15:58, address@hidden a écrit :
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [PATCH v3 00/12] linux-user sparc fixes
> Type: series
> Message-id: address@hidden
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  - [tag update]      patchew/address@hidden -> patchew/address@hidden
>  - [tag update]      patchew/address@hidden -> patchew/address@hidden
>  * [new tag]         patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> 33486ee linux-user/alpha: Set r20 secondary return value
> 4c5f970 linux-user/sparc: Fix cpu_clone_regs_*
> 38c0642 linux-user: Introduce cpu_clone_regs_parent
> 8fd10b2 linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
> 1c6ebcb linux-user/sparc64: Fix target_signal_frame
> b1257ef linux-user/sparc: Fix WREG usage in setup_frame
> 5f40252 linux-user/sparc: Use WREG_SP constant in sparc/signal.c
> 2e7ffe6 linux-user/sparc: Begin using WREG constants in sparc/signal.c
> b87f31db linux-user/sparc: Use WREG constants in sparc/target_cpu.h
> 08fdb43 target/sparc: Define an enumeration for accessing env->regwptr
> 7e876dd tests/tcg/multiarch/linux-test: Fix error check for shmat
> 4dae54d scripts/qemu-binfmt-conf: Update for sparc64
> 
> === OUTPUT BEGIN ===
> 1/12 Checking commit 4dae54d6afb3 (scripts/qemu-binfmt-conf: Update for 
> sparc64)
> WARNING: line over 80 characters
> #36: FILE: scripts/qemu-binfmt-conf.sh:41:
> +sparc64_magic='\x7fELF\x02\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x2b'
> 
> ERROR: line over 90 characters
> #37: FILE: scripts/qemu-binfmt-conf.sh:42:
> +sparc64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
> 

All magic and mask are like this in scripts/qemu-binfmt-conf.sh, these
errors can be ignored.

Thanks,
Laurent