Re: [RFC PATCH] tests/vm: make --interactive (and therefor DEBUG=1) unconditional

[Eric Blake]

On 11/12/19 9:10 AM, Alex Bennée wrote:

In the subject: s/therefor/therefore/

> While the concepts of only dropping to ssh if a test fails is nice it

s/concepts/concept/

> is more useful for this to be unconditional. You usually just want to
> get the build up and running and then noodle around debugging or
> attempting to replicate.
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>   tests/vm/basevm.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
> index 91a9226026d..0b8c1b26576 100755
> --- a/tests/vm/basevm.py
> +++ b/tests/vm/basevm.py
> @@ -403,7 +403,7 @@ def main(vmcls):
>       exitcode = 0
>       if vm.ssh(*cmd) != 0:
>           exitcode = 3
> -    if exitcode != 0 and args.interactive:
> +    if args.interactive:
>           vm.ssh()
>   
>       if not args.snapshot:

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org