Re: [PATCH] WHPX: refactor load library

[Paolo Bonzini]

On 08/11/19 21:31, Sunil Muthuswamy wrote:
> 
> +typedef enum WHPFunctionList {
> +    WINHV_PLATFORM_FNS_DEFAULT,
> +    WINHV_EMULATION_FNS_DEFAULT,
> +} WHPFunctionList;
>  

What does "default" stand for?  I assume you have more changes to this
function in the future.

> + * Load the functions from the given library, using the given handle. If a
> + * handle is provided, it is used, otherwise the library is opened. The
> + * handle will be updated on return with the opened one.
> + */
> +static bool load_whp_dipatch_fns(HMODULE *handle, WHPFunctionList 
> function_list)
> +{

Typo, "dipatch" instead of "dispatch".
> 
> +    if (hLib) {
> +        FreeLibrary(hWinHvEmulation);
> +    }

The argument to FreeLibrary should be hLib.

Paolo