|
From: | Jag Raman |
Subject: | Re: [RFC v4 PATCH 02/49] multi-process: util: Add qemu_thread_cancel() to cancel running thread |
Date: | Wed, 13 Nov 2019 11:04:58 -0500 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 |
On 11/13/2019 10:51 AM, Daniel P. Berrangé wrote:
On Wed, Nov 13, 2019 at 10:38:06AM -0500, Jag Raman wrote:On 11/13/2019 10:30 AM, Stefan Hajnoczi wrote:On Thu, Oct 24, 2019 at 05:08:43AM -0400, Jagannathan Raman wrote:qemu_thread_cancel() added to destroy a given running thread. This will be needed in the following patches. Signed-off-by: John G Johnson <address@hidden> Signed-off-by: Jagannathan Raman <address@hidden> Signed-off-by: Elena Ufimtseva <address@hidden> --- include/qemu/thread.h | 1 + util/qemu-thread-posix.c | 10 ++++++++++ 2 files changed, 11 insertions(+)Is this still needed? I thought previous discussion concluded that thread cancellation is hard to get right and it's not actually used by this series?Hi Stefan, This is used in PATCH 41/49.I don't believe the cancellation usage in that patch is safe :-)
Thanks for the feedback, we will address that. May I please ask why it is not safe? Any clarification will help us to find a better alternative. Thank you very much! -- Jag
Regards, Daniel
[Prev in Thread] | Current Thread | [Next in Thread] |