[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_
|
From: |
Alberto Garcia |
|
Subject: |
Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_slice() |
|
Date: |
Thu, 14 Nov 2019 16:33:35 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 04 Nov 2019 04:07:35 PM CET, Max Reitz wrote:
>> /* First remove L2 entries */
>> qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
>> - if (!full_discard && s->qcow_version >= 3) {
>> + if (has_subclusters(s)) {
>> + set_l2_entry(s, l2_slice, l2_index + i, 0);
>> + set_l2_bitmap(s, l2_slice, l2_index + i,
>> + full_discard ? 0 : QCOW_L2_BITMAP_ALL_ZEROES);
>
> But only for !full_discard, right?
Hence the conditional operator in my patch, maybe you didn't see it?
Berto