[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate seri
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize |
|
Date: |
Thu, 14 Nov 2019 18:15:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 14.11.19 17:27, Christoph Hellwig wrote:
> On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote:
>> The XFS kernel driver has a bug that may cause data corruption for qcow2
>> images as of qemu commit c8bb23cbdbe32f. We can work around it by
>> treating post-EOF fallocates as serializing up until infinity (INT64_MAX
>> in practice).
>
> This has been fixed in the kernel a while ago. I don't think it makes
> sense to work around it in qemu.
Has it? It was my understanding that this is fixed by
https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git/commit/?h=for-next&id=249bd9087a5264d2b8a974081870e2e27671b4dcwhich
has been merged only very recently and is on track to be part of Linux
5.5, as far as I understand.
Max
signature.asc
Description: OpenPGP digital signature