[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vfio: don't ignore return value of migrate_add_blocker
|
From: |
Stefano Garzarella |
|
Subject: |
Re: [PATCH] vfio: don't ignore return value of migrate_add_blocker |
|
Date: |
Fri, 15 Nov 2019 09:59:38 +0100 |
On Thu, Nov 14, 2019 at 02:34:49PM +0100, Jens Freimann wrote:
> When an error occurs in migrate_add_blocker() it sets a
> negative return value and uses error pointer we pass in.
> Instead of just looking at the error pointer check for a negative return
> value and avoid a coverity error because the return value is
> set but never used. This fixes CID 1407219.
>
> Fixes: f045a0104c8c ("vfio: unplug failover primary device before
> migration")
> Signed-off-by: Jens Freimann <address@hidden>
> ---
> hw/vfio/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <address@hidden>