[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/16] vl: extract accelerator option processing to a separat
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 02/16] vl: extract accelerator option processing to a separate function |
Date: |
Mon, 18 Nov 2019 12:39:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 18/11/19 11:58, Thomas Huth wrote:
>> +static void configure_accelerators(void)
>> +{
>> + qemu_opts_foreach(qemu_find_opts("icount"),
>> + do_configure_icount, NULL, &error_fatal);
>> +
>> + qemu_opts_foreach(qemu_find_opts("accel"),
>> + do_configure_accelerator, NULL, &error_fatal);
>> +}
>
> vl.c is already quite overcrowded ... maybe you could add the new code
> to accel/accel.c instead? Just my 0.02 €.
I liked the idea of keeping all command line parsing in vl.c, especially
because all the ugliness for backwards compatibility can then be
confined there.
Paolo
- [PATCH for-5.0 00/16] Complete the implementation of -accel, Paolo Bonzini, 2019/11/13
- [PATCH 02/16] vl: extract accelerator option processing to a separate function, Paolo Bonzini, 2019/11/13
- [PATCH 01/16] memory: do not look at current_machine->accel, Paolo Bonzini, 2019/11/13
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Thomas Huth, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Paolo Bonzini, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Thomas Huth, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Peter Maydell, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Paolo Bonzini, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Peter Maydell, 2019/11/14