[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/16] vl: move icount configuration earlier
From: |
Thomas Huth |
Subject: |
Re: [PATCH 04/16] vl: move icount configuration earlier |
Date: |
Mon, 18 Nov 2019 12:53:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 |
On 13/11/2019 15.38, Paolo Bonzini wrote:
> Once qemu_tcg_configure is turned into a QOM property setter, it will not
> be able to set a default value for mttcg_enabled. Setting the default will
> move to the TCG init_machine method, which currently runs after "-icount"
> is processed.
>
> However, it is harmless to do configure_icount for all accelerators; we will
> just fail later if a non-TCG accelerator being selected. So do that.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> vl.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, (continued)
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Thomas Huth, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Paolo Bonzini, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Thomas Huth, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Peter Maydell, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Paolo Bonzini, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Peter Maydell, 2019/11/14
- Re: [PATCH 01/16] memory: do not look at current_machine->accel, Paolo Bonzini, 2019/11/14
[PATCH 04/16] vl: move icount configuration earlier, Paolo Bonzini, 2019/11/13
[PATCH 03/16] vl: merge -accel processing into configure_accelerators, Paolo Bonzini, 2019/11/13
[PATCH 05/16] vl: introduce object_parse_property_opt, Paolo Bonzini, 2019/11/13
[PATCH 06/16] vl: configure accelerators from -accel options, Paolo Bonzini, 2019/11/13