[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 02/11] gdbstub: stop passing GDBState * around
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC PATCH 02/11] gdbstub: stop passing GDBState * around |
|
Date: |
Mon, 18 Nov 2019 12:57:48 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 11/18/19 12:52 PM, Alex Bennée wrote:
>> Modulo my question about why not use a non-pointer variable,
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>
> Sure - we might as well go for static assignment. My main worry was
> overly long lines but we could shorten the global to compensate or wrap
> a helper around.
You could use a shorter variable name, I suppose,
though a good name is not immediately leaping to mind...
r~
- Re: [RFC PATCH 05/11] gdbstub: add helper for 128 bit registers, (continued)
- [RFC PATCH 04/11] gdbstub: move mem_buf to GDBState and use GByteArray, Alex Bennée, 2019/11/15
- [RFC PATCH 07/11] target/m68k: use gdb_get_reg helpers, Alex Bennée, 2019/11/15
- [RFC PATCH 03/11] gdbstub: move str_buf to GDBState and use GString, Alex Bennée, 2019/11/15
- [RFC PATCH 02/11] gdbstub: stop passing GDBState * around, Alex Bennée, 2019/11/15
- Re: [RFC PATCH 02/11] gdbstub: stop passing GDBState * around, Damien Hedde, 2019/11/18
- [RFC PATCH 10/11] target/arm: explicitly encode regnum in our XML, Alex Bennée, 2019/11/15
- [RFC PATCH 09/11] target/arm: prepare for multiple dynamic XMLs, Alex Bennée, 2019/11/15
- [RFC PATCH 11/11] target/arm: generate xml description of our SVE registers, Alex Bennée, 2019/11/15
- [RFC PATCH 08/11] gdbstub: extend GByteArray to read register helpers, Alex Bennée, 2019/11/15