qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 01/33] qdev: remove unused qdev_prop_int64


From: Peter Maydell
Subject: Re: [PATCH v3 01/33] qdev: remove unused qdev_prop_int64
Date: Mon, 18 Nov 2019 14:01:16 +0000

On Wed, 23 Oct 2019 at 18:32, Marc-André Lureau
<address@hidden> wrote:
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  hw/core/qdev-properties.c    | 32 --------------------------------
>  include/hw/qdev-properties.h |  3 ---
>  2 files changed, 35 deletions(-)

I think I'd rather keep this. It's weird to not have a symmetric
set of properties for the common integer types, and annoying
for whoever next runs into a need for an int64 property to
have to reinstate the deleted code. (Yes, I know we don't
currently have int8 or int16.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]