[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] net/cadence_gem: Set PHY autonegotiation restart status
From: |
Peter Maydell |
Subject: |
Re: [PATCH] net/cadence_gem: Set PHY autonegotiation restart status |
Date: |
Mon, 18 Nov 2019 17:24:47 +0000 |
On Mon, 18 Nov 2019 at 17:21, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> On 11/5/19 12:31 PM, Linus Ziegert wrote:
> > Am Mo., 4. Nov. 2019 um 23:50 Uhr schrieb Alistair Francis
> > <address@hidden <mailto:address@hidden>>:
> > >
> > > On Mon, Nov 4, 2019 at 2:02 PM <address@hidden
> > <mailto:address@hidden>> wrote:
> > > >
> > > > From: Linus Ziegert <address@hidden
> > <mailto:address@hidden>>
> > > >
> > > > The Linux kernel PHY driver sets AN_RESTART in the BMCR of the
> > > > PHY when autonegotiation is started.
> > > > Recently the kernel started to read back the PHY's AN_RESTART
> > > > bit and now checks whether the autonegotiation is complete and
> > > > the bit was cleared [1]. Otherwise the link status is down.
> > > >
> > > > The emulated PHY needs to clear AN_RESTART immediately to inform
> > > > the kernel driver about the completion of autonegotiation phase.
> > > >
> > > > [1]
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c36757eb9dee
> > > >
> > > > Signed-off-by: Linus Ziegert <address@hidden
> > <mailto:address@hidden>>
> > >
> > > Reviewed-by: Alistair Francis <address@hidden
> > <mailto:address@hidden>>
> >
> > I consider this stable material. Applies cleanly to all versions
> > starting from v1.5.0.
>
> Too bad this wasn't Cc'ed to address@hidden and missed 4.1.1
> stable release.
I can take it via target-arm since it only affects an arm board.
thanks
-- PMM