[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] tests/vm: make --interactive (and therefore DEBUG=1) uncondit
|
From: |
Alex Bennée |
|
Subject: |
[PULL 1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional |
|
Date: |
Wed, 20 Nov 2019 10:57:57 +0000 |
While the concept of only dropping to ssh if a test fails is nice it
is more useful for this to be unconditional. You usually just want to
get the build up and running and then noodle around debugging or
attempting to replicate.
Cc: Peter Maydell <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 91a9226026d..0b8c1b26576 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -403,7 +403,7 @@ def main(vmcls):
exitcode = 0
if vm.ssh(*cmd) != 0:
exitcode = 3
- if exitcode != 0 and args.interactive:
+ if args.interactive:
vm.ssh()
if not args.snapshot:
--
2.20.1
- [PULL for rc3 0/5] a few doc and testing tweaks, Alex Bennée, 2019/11/20
- [PULL 2/5] docs/devel: rename plugins.rst to tcg-plugins.rst, Alex Bennée, 2019/11/20
- [PULL 5/5] tests/tcg: modify multiarch tests to work with clang, Alex Bennée, 2019/11/20
- [PULL 1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional,
Alex Bennée <=
- [PULL 3/5] docs/devel: update tcg-plugins.rst with API versioning details, Alex Bennée, 2019/11/20
- [PULL 4/5] .travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS, Alex Bennée, 2019/11/20
- Re: [PULL for rc3 0/5] a few doc and testing tweaks, Peter Maydell, 2019/11/21